Skip to content

Add support for tt.dot using 3d tensors - #13

Closed
enjustli wants to merge 1 commit into
facebookincubator:mainfrom
enjustli:fork_ms_pr_352
Closed

Add support for tt.dot using 3d tensors#13
enjustli wants to merge 1 commit into
facebookincubator:mainfrom
enjustli:fork_ms_pr_352

Conversation

@enjustli

Copy link
Copy Markdown
Contributor

fork from microsoft/triton-shared#352

Really simple change to emit linalg.batch_matmul instead of linalg.matmul if the input to tt.dot is a 3d tensor.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 31, 2026
@nhat-nguyen

Copy link
Copy Markdown
Contributor

I'd be more inclined to wait for the original authors to continue their work here rather than just proactively fork all PRs.

@enjustli

enjustli commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

I'd be more inclined to wait for the original authors to continue their work here rather than just proactively fork all PRs.

Maybe we’ll have to wait until the heat death of the universe. 😂 I thought it’s fine to just fork it over directly, just go ahead and review it as usual. I’ll follow up on any issues if they come up.

@enjustli

enjustli commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

such as this pr: triton-lang/triton#8766

@enjustli

enjustli commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

I mean no disrespect to the original author. I’ve also acknowledged the source of the fork in the comments.

@nhat-nguyen

nhat-nguyen commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

I personally think as a common courtesy, it's better to let the original authors complete their original work. Also licensing and legal matters are complicated. The original authors agreed to Microsoft's CLA -- not Meta's CLA. So I'm not really sure if we can just directly copy the work over here. To be safe on the legal safe and courteous to the original authors, would you mind closing these PRs and asking them if they have any interests in carrying these over themselves?

@enjustli

enjustli commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

I don't know to contact them, and I don’t really have the time to pursue that. I brought these PRs over because they seemed helpful to the triton-shared project.
Since there are potential legal risks, then I’m fine with dropping this.
If others run into similar issues in the future, they’ll likely submit new PRs.

@enjustli enjustli closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants